mahara-contributors team mailing list archive

[Niranjan <1560780@xxxxxxxxxxxxxxxxxx>]

URL: https://bugs.launchpad.net/mahara/+bug/1560780

Bug description: Allowing button tag in the tinymce

Environment to be tested: Master
Browser to be tested: Any browser

Precondition: 
1. A normal user ‘User one’ should exist.
2. A group ‘Group one’ should exist.

Steps to reproduce:

1. Log in as a ‘User one’.
2.  Navigate to Main menu > Portfolio > Pages and collections.
3. Click the ‘Add’ button.
4. Click the ‘Page’ button.
5. Enter the ‘Page title’ as ‘Page 01’.
6. Click the ‘Toggle toolbar’ icon under ‘Page description’ to show full list of buttons.
7. Click the ‘Source code’ button.
8. Enter the string ‘<button type=”button” class=”btn btn-warning”>warning</button>’ in the edit box.
9. Click the ‘Ok’ button

Expected result: A button with the text ‘warning’ should be displayed
under the ‘Page description’.

10. Click the ‘Save’ button.
11. Click the ‘Display page’ button.

Expected result: A button with the text 'warning' should be displayed
under the page title.

Note: There is no heading "Page description" on the page when you view
it.

12. Click the ‘Edit this page’ button.
13. Click the ‘Text’ label.
14. Click the ‘Add’ button.
15. Click the ‘Toggle toolbar’ icon to show full list of buttons.
16. Click the ‘Source code’ button.
17. Enter the string ‘<button type=”button” class=”btn btn-warning”>warning</button>’ in the edit box.
18. Click the ‘Ok’ button.

Expected result: A button with the text ‘warning’ should be displayed
under the ‘Block content’.

19. Click the ‘Save’ button.

Expected result: A button with the text ‘warning’ should be displayed in
the 'Text' block.

Note: The text is part of the block and thus is within it and not under
it.

20. Navigate to Main menu > Content > Journals.
21. Click the ‘New entry’ button.
22. Enter the title  ‘Entry one’.
23. Click the ‘Toggle toolbar’ icon under ‘Entry’ to show full list of buttons.
24. Click the ‘Source code’ button.
25. Enter the string ‘<button type=”button” class=”btn btn-warning”>warning</button>’ in the edit box.
26. Click the ‘Ok’ button.

Expected result: A button with the text ‘warning’ should be displayed.

27. Click the ‘Save entry’ button.

Expected result: A button with the text ‘warning’ should be displayed
under the ‘Entry one’ journal.

28. Navigate to Main menu > Groups > Group one.
29. Click the ‘Forums’ tab.
30. Click the ‘New forum’ button.
31. Enter the title as ‘ Title one’.
32. Click the ‘Toggle toolbar’ icon under ‘Description’ to show full list of buttons.
33. Click the ‘Source code’ button.
34. Enter the string ‘<button type=”button” class=”btn btn-warning”>warning</button>’ in the edit box.
35. Click the ‘Ok’ button.
36. Save the entry.

Expected result: A button with the text ‘warning’ should be displayed.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1560780

Title:
  Allow 'button' tags to be valid in clean_html

Status in Mahara:
  In Progress

Bug description:
  If I want to add a string like:

  <button type="button" class="btn btn-warning">Warning</button>

  To tinymce to display a bootstrap type button it doesn't display as
  the clean_html() htmlpurifier strips it out

  Can / should we allow <button> to be not  stripped out?

  See forum question:
  https://mahara.org/interaction/forum/topic.php?id=7550&offset=0&limit=10#post30356

  Adding $def->addElement('button', 'Inline', 'Inline', 'Common'); to
  clean_html() will allow button to show after saving.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1560780/+subscriptions