mahara-contributors team mailing list archive

[Mahara Bot <1560780@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8249
Committed: https://git.mahara.org/mahara/mahara/commit/a6f2b0075b5f500be447ef89df575898e13d0985
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit a6f2b0075b5f500be447ef89df575898e13d0985
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Nov 1 07:24:25 2017 +1300

Bug 1560780: Allowing 'button' tag in tinymce

behatnotneeded

Change-Id: I84b1c6286bc066ceb830732082f8dc9f8fcdbe20
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1560780

Title:
  Allow 'button' tags to be valid in clean_html

Status in Mahara:
  Fix Committed

Bug description:
  If I want to add a string like:

  <button type="button" class="btn btn-warning">Warning</button>

  To tinymce to display a bootstrap type button it doesn't display as
  the clean_html() htmlpurifier strips it out

  Can / should we allow <button> to be not  stripped out?

  See forum question:
  https://mahara.org/interaction/forum/topic.php?id=7550&offset=0&limit=10#post30356

  Adding $def->addElement('button', 'Inline', 'Inline', 'Common'); to
  clean_html() will allow button to show after saving.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1560780/+subscriptions