mahara-contributors team mailing list archive

[Mahara Bot <1738303@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8364
Committed: https://git.mahara.org/mahara/mahara/commit/fef8c68dbdc97545c6da83e19d560cccc85d034f
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    master

commit fef8c68dbdc97545c6da83e19d560cccc85d034f
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Dec 15 13:13:34 2017 +1300

Bug 1738303: Remove the obsolete $new variable being passed about when
creating a new page.

It is mostly so we can show 'No title' for page name and to have a
'back' button instead of 'edit page' when viewing ones own page.

But we don't need it as a page has a title when we click 'add page' as
we make the new view entry in database straight away and the title
will be something like 'Untitled v.2'.

And if we change the title on page settings form then block edit screen
will now show new correct title instead of 'No title'

behatnotneeded

Change-Id: I4630d53fbee734f1f4e903c05aa92b8348f3f41f
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1738303

Title:
  Legacy code passes around a $new value when creating a new page but it
  is not needed

Status in Mahara:
  Fix Committed

Bug description:
  We only need the $new variable on the editlayout.php page because
  after that the view exists in db and so we can just display it's real
  title rather than 'No title'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1738303/+subscriptions