mahara-contributors team mailing list archive

[Mahara Bot <1463629@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8740
Committed: https://git.mahara.org/mahara/mahara/commit/7175f91e1295b7db52bc1302fda3c08305dc113d
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 7175f91e1295b7db52bc1302fda3c08305dc113d
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Wed Jun 10 12:33:49 2015 +1200

Bug 1759367: Cherry-pick for Prevent HTTP iframes on an HTTPS site

Cherry pick of Bug 1463629 for the upgrade of html purifier to 4.10.0

behatnotneeded

Change-Id: I0c89f64f567d55b8a9ffd3772bdc23563103a93d

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1463629

Title:
  Prevent HTTP iframes on HTTPS sites

Status in Mahara:
  Fix Released
Status in Mahara 1.10 series:
  Fix Released
Status in Mahara 1.9 series:
  Fix Released
Status in Mahara 15.04 series:
  Fix Released

Bug description:
  We've reached a point now where Firefox, Chrome, and IE will all
  silently ignore an HTTP iframe on an HTTPS site.

  Most iframe embed provides now provide an https or protocol-relative
  iframe code, but occasionally a user will still enter an http iframe,
  maybe from a site that isn't up to snuff yet, or copied from an older
  page. This leads to the unsatisfactory user experience where they've
  entered an iframe code, but the iframe doesn't show up at all.

  We should change our safe iframe code so that it detects these HTTP
  iframes and rewrites them to HTTPS or protocol-relative.

  This is also a bit of a security issue (mixing HTTP content on an
  HTTPS page) but since all modern browsers simply ban the unsafe
  iframe, it's a low-priority security issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1463629/+subscriptions