mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

Public bug reported:

We added a bit of code that made sure that when we install a site it
changes the admin email from admin@xxxxxxxxxxx to the one supplied in
all 3 places where we save email addresses - we save this directly to
db.

This is ok if we then log out before going to a place in Mahara where
$USER->commit() is called

But if we don't the $USER object still has admin@xxxxxxxxxxx set so
overwrites our change in the usr table.

We need to commit this change via the USER object rather than update the
usr table directly

** Affects: mahara
     Importance: High
         Status: In Progress

** Affects: mahara/16.10
     Importance: High
         Status: Confirmed

** Affects: mahara/17.04
     Importance: High
         Status: Confirmed

** Affects: mahara/17.10
     Importance: High
         Status: Confirmed

** Affects: mahara/18.04
     Importance: High
         Status: In Progress

** Affects: mahara/18.10
     Importance: High
         Status: In Progress

** Also affects: mahara/17.10
   Importance: Undecided
       Status: New

** Also affects: mahara/18.10
   Importance: Undecided
       Status: New

** Also affects: mahara/16.10
   Importance: Undecided
       Status: New

** Also affects: mahara/18.04
   Importance: Undecided
       Status: New

** Also affects: mahara/17.04
   Importance: Undecided
       Status: New

** Changed in: mahara/18.10
   Importance: Undecided => High

** Changed in: mahara/18.04
   Importance: Undecided => High

** Changed in: mahara/17.10
   Importance: Undecided => High

** Changed in: mahara/17.04
   Importance: Undecided => High

** Changed in: mahara/16.10
   Importance: Undecided => High

** Changed in: mahara/18.10
    Milestone: None => 18.10.0

** Changed in: mahara/18.04
    Milestone: None => 18.04.0

** Changed in: mahara/17.10
    Milestone: None => 17.10.4

** Changed in: mahara/17.04
    Milestone: None => 17.04.7

** Changed in: mahara/16.10
    Milestone: None => 16.10.9

** Changed in: mahara/18.10
       Status: New => In Progress

** Changed in: mahara/18.04
       Status: New => In Progress

** Changed in: mahara/17.10
       Status: New => Confirmed

** Changed in: mahara/17.04
       Status: New => Confirmed

** Changed in: mahara/16.10
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1761037

Title:
  Installing a site doesn't update email correctly

Status in Mahara:
  In Progress
Status in Mahara 16.10 series:
  Confirmed
Status in Mahara 17.04 series:
  Confirmed
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  In Progress
Status in Mahara 18.10 series:
  In Progress

Bug description:
  We added a bit of code that made sure that when we install a site it
  changes the admin email from admin@xxxxxxxxxxx to the one supplied in
  all 3 places where we save email addresses - we save this directly to
  db.

  This is ok if we then log out before going to a place in Mahara where
  $USER->commit() is called

  But if we don't the $USER object still has admin@xxxxxxxxxxx set so
  overwrites our change in the usr table.

  We need to commit this change via the USER object rather than update
  the usr table directly

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1761037/+subscriptions