mahara-contributors team mailing list archive

[Mahara Bot <1761037@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8771
Committed: https://git.mahara.org/mahara/mahara/commit/d4842eddd02bededa9847bfc2dddec8b6fc60d9e
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    17.10_STABLE

commit d4842eddd02bededa9847bfc2dddec8b6fc60d9e
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Apr 4 14:19:53 2018 +1200

Bug 1761037: Commit the email update on first install correctly

Rather than update db directly - we need to update the USER object

behatnotneeded

Change-Id: I31f8c6759dd621439c90ddc0f0dc8a344359d5d9
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 4adf4a015e4ecb0130292849eb19d162b391daa2)
(cherry picked from commit 6905c539a4d0b36a0fe56a10c2d0963c43bc1240)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1761037

Title:
  Installing a site doesn't update email correctly

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  We added a bit of code that made sure that when we install a site it
  changes the admin email from admin@xxxxxxxxxxx to the one supplied in
  all 3 places where we save email addresses - we save this directly to
  db.

  This is ok if we then log out before going to a place in Mahara where
  $USER->commit() is called

  But if we don't the $USER object still has admin@xxxxxxxxxxx set so
  overwrites our change in the usr table.

  We need to commit this change via the USER object rather than update
  the usr table directly

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1761037/+subscriptions