mahara-contributors team mailing list archive

[Cecilia Vela Gurovic <1804328@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

When adding a comment, the text can include html tags with classes that
might interfere with the styling classes used by core. This could break
the functionality of the page.

To replicate

- create a page and display it
- at the bottom, in the comment text area, expand the toolbar
- click on the 'Source code' button and add the text:

<div class="post list-group-item clearfix flush">
<div id="user_feedbacktable_0123456789" class="feedback modal modal-docked">
<div class="modal-dialog modal-lg">
<div class="modal-content">
<div class="modal-body flush">
<div class="list-group list-group-lite">
<div id="user_comment12345" class="comment-item list-group-item list-group-item-warning r0">
<div class="comment-text">
<div class="comment-content">
<p>Comment text.</p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<div class="post list-group-item clearfix flush"> </div></div>


Expected result:
- The page refreshes and the text "Comment text." is displayed

Actual result:
- The comment is not displayed

** Affects: mahara
     Importance: High
     Assignee: Cecilia Vela Gurovic (ceciliavg)
         Status: In Progress

** Changed in: mahara
    Milestone: None => 19.04.0

** Changed in: mahara
     Assignee: (unassigned) => Cecilia Vela Gurovic (ceciliavg)

** Changed in: mahara
   Importance: Undecided => High

** Changed in: mahara
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1804328

Title:
  need to clean html tag classes in comments

Status in Mahara:
  In Progress

Bug description:
  When adding a comment, the text can include html tags with classes
  that might interfere with the styling classes used by core. This could
  break the functionality of the page.

  To replicate

  - create a page and display it
  - at the bottom, in the comment text area, expand the toolbar
  - click on the 'Source code' button and add the text:

  <div class="post list-group-item clearfix flush">
  <div id="user_feedbacktable_0123456789" class="feedback modal modal-docked">
  <div class="modal-dialog modal-lg">
  <div class="modal-content">
  <div class="modal-body flush">
  <div class="list-group list-group-lite">
  <div id="user_comment12345" class="comment-item list-group-item list-group-item-warning r0">
  <div class="comment-text">
  <div class="comment-content">
  <p>Comment text.</p>
  </div>
  </div>
  </div>
  </div>
  </div>
  </div>
  </div>
  </div>
  </div>
  <div class="post list-group-item clearfix flush"> </div></div>

  
  Expected result:
  - The page refreshes and the text "Comment text." is displayed

  Actual result:
  - The comment is not displayed

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1804328/+subscriptions