mahara-contributors team mailing list archive

[Mahara Bot <1804328@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/9328
Committed: https://git.mahara.org/mahara/mahara/commit/ca51e4f73ee2fc2a59707bbe217c10c5be577665
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    18.04_STABLE

commit ca51e4f73ee2fc2a59707bbe217c10c5be577665
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date:   Wed Nov 21 12:07:11 2018 +1300

Bug 1804328: Clean 'modal' and 'modal-..' classes from comments

behatnotneeded

Change-Id: I5b59c45ef7b84b947615ed4ccd8a0651aa935fdb
(cherry picked from commit c7dc45bc00574129b6621473062a12a3200d2403)
(cherry picked from commit 65a23474b629f4eddb058457310a8f0cecfbadb2)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1804328

Title:
  need to clean html tag classes in comments

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  When adding a comment, the text can include html tags with classes
  that might interfere with the styling classes used by core. This could
  break the functionality of the page.

  To replicate

  - create a page and display it
  - at the bottom, in the comment text area, expand the toolbar
  - click on the 'Source code' button and add the text:

  <div class="post list-group-item clearfix flush">
  <div id="user_feedbacktable_0123456789" class="feedback modal modal-docked active">
  <div class="modal-dialog modal-lg">
  <div class="modal-content">
  <div class="modal-body flush">
  <div class="list-group list-group-lite">
  <div id="user_comment12345" class="comment-item list-group-item list-group-item-warning r0">
  <div class="comment-text">
  <div class="comment-content">
  <p>Comment text.</p>
  </div>
  </div>
  </div>
  </div>
  </div>
  </div>
  </div>
  </div>
  </div>
  <div class="post list-group-item clearfix flush"> </div></div>

  Expected result:
  - The page refreshes and the text "Comment text." is displayed

  Actual result:
  - The comment is not displayed

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1804328/+subscriptions