mahara-contributors team mailing list archive

[Mahara Bot <1813519@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/9516
Committed: https://git.mahara.org/mahara/mahara/commit/ab554b34219b1df7246276e71d1111622c3d7491
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit ab554b34219b1df7246276e71d1111622c3d7491
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Fri Feb 1 12:47:30 2019 +1300

Bug 1813519: Translation issues for forum unsubscribe links

Added translation string for forumlower to lang file (english, de)
In lib.php where email message is made,
changed $user->subscribetype to explicityly
translate it with get_string_from_language func

behatnotneeded

Change-Id: I4551160b153c6a93bb455fa988bdafcd2f3e0606
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1813519

Title:
  Translation issues for forum unsubscribe link

Status in Mahara:
  Fix Committed

Bug description:
  An issue has been encountered when translating "Unsubscribe from this
  %s".

  The two possibilities are:

  Unsubscribe from this forum
  Unsubscribe from this topic

  In German though the English "forum" / "topic" is inserted even though
  the normal %s is used in the translation even though both "forum" and
  "topic" have been translated.

  These strings come up in
  /interaction/forum/lang/en.utf8/interaction.forum.php string
  forumposthtmltemplate

  I can't figure out why the German translation wouldn't be shown for
  "forum" / "topic".

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1813519/+subscriptions