← Back to team overview

mahara-contributors team mailing list archive

[Bug 1836017] [NEW] Tag cloud invalid font size

 

Public bug reported:

Font size in Tag cloud side block is not generated right. Font size is generated in lin/mahara.php, line 3985 (function get_my_tags). Code to generate tag is:
$t->size = sprintf("%0.1f", $minsize + ($maxsize - $minsize) * $weight);

Specifier f in sprintf function is local aware so in languages that use comma as decimal separator (like Croatian language) it will generate invalid value for HTML font size. Fix is simple, just use non-locale aware specifier:
$t->size = sprintf("%0.1F", $minsize + ($maxsize - $minsize) * $weight);

This will always generate decimal number with period as a decimal
separator.

** Affects: mahara
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1836017

Title:
  Tag cloud invalid font size

Status in Mahara:
  New

Bug description:
  Font size in Tag cloud side block is not generated right. Font size is generated in lin/mahara.php, line 3985 (function get_my_tags). Code to generate tag is:
  $t->size = sprintf("%0.1f", $minsize + ($maxsize - $minsize) * $weight);

  Specifier f in sprintf function is local aware so in languages that use comma as decimal separator (like Croatian language) it will generate invalid value for HTML font size. Fix is simple, just use non-locale aware specifier:
  $t->size = sprintf("%0.1F", $minsize + ($maxsize - $minsize) * $weight);

  This will always generate decimal number with period as a decimal
  separator.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1836017/+subscriptions


Follow ups