mahara-contributors team mailing list archive

[Mahara Bot <1836017@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10313
Committed: https://git.mahara.org/mahara/mahara/commit/ad4dd6af38bbf16206088bc66d08c443e26ebecf
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit ad4dd6af38bbf16206088bc66d08c443e26ebecf
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Sep 9 08:17:45 2019 +1200

Bug 1836017: Using the non-locale aware floating-point number

To avoid languages that use comma as decimal separator (like Croatian
language)

behatnotneeded

Change-Id: I8ff67de7119bb4910750e99859d152ea960a09de
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1836017

Title:
  Tag cloud invalid font size

Status in Mahara:
  Fix Committed

Bug description:
  Font size in Tag cloud side block is not generated right. Font size is generated in lin/mahara.php, line 3985 (function get_my_tags). Code to generate tag is:
  $t->size = sprintf("%0.1f", $minsize + ($maxsize - $minsize) * $weight);

  Specifier f in sprintf function is local aware so in languages that use comma as decimal separator (like Croatian language) it will generate invalid value for HTML font size. Fix is simple, just use non-locale aware specifier:
  $t->size = sprintf("%0.1F", $minsize + ($maxsize - $minsize) * $weight);

  This will always generate decimal number with period as a decimal
  separator.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1836017/+subscriptions