mahara-contributors team mailing list archive

[Mahara Bot <1827811@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10355
Committed: https://git.mahara.org/mahara/mahara/commit/f5ca6b3aa22a682e9596ea20539f96a6ef3f8cab
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    master

commit f5ca6b3aa22a682e9596ea20539f96a6ef3f8cab
Author: Evonne <evonne@xxxxxxxxxxxxxxx>
Date:   Wed Sep 18 15:09:27 2019 +1200

Bug 1827811: Journal and resume details buttons overlap

Fixes for journal titles and resume attachments for employment
overlapped by details button.

behatnotneeded

- clean up unneccessary include in export/html/lib.php
- fix html export for the creation of nested folder modals
make sure the nested folders and find all nested modals
- fix elseif typo in block-comments-details-header.tpl
- add details bar to image gallery when displayed from folders
- fix notes block empty modal issue due to .tpl typo
- fix image gallery slideshow error where second gallery block
always targets the first
- keep the active block headers showing after pagination update

Change-Id: Icf8d59ad558d74883e3ee2070f55768697af4254

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1827811

Title:
  Move "Add comment" and "Details" into modal with "Comments"

Status in Mahara:
  In Progress

Bug description:
  This is part of the page revamp:
  https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/Page_layout_revision

  Currently, the "Add comment" and "Details" links at blocks that can
  have them, takes you to a separate page where you can view the
  artefact's metadata and can leave comments.

  When you view comments, they are already displayed in the modal
  directly on the page, but you can't leave a comment yet.

  The things to be done:

  - Combine comments, add comment, Details to "Comments and details" (or just comments or just details depending on what can be displayed) so you only have one link.
  - Clicking that link opens up a modal on the page that shows the artefacts details (if there are any) and also the comments, as well as allows you to leave comments if that is enabled. Please see the attached mock-up.

  This would also mean to review all the "Details" on blocks as some of
  them are not needed. For example, clicking the details link next to a
  plan task only shows that single plan task again without any
  additional details. The "Details" should only be there when there is
  additional metadata information but not simply repeating the block
  content.

  The title of the modal (the one in the green bar) would be the
  blocktype as the title of the block is listed below.

  A decision still needs to be made on whether comments can be paginated
  in the modal or if they are shown all one after another (which might
  get quite long).

  We are not changing anything else from the proposal as that requires
  Gridstack to be implemented first. This is a standalone usability
  improvement independent of Gridstack.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1827811/+subscriptions