mahara-contributors team mailing list archive

[Rangi Daymond <1827811@xxxxxxxxxxxxxxxxxx>]

**Gerrit/Patchset: https://reviews.mahara.org/mahara refs/changes/55/10355/11
**Browser tested: Firefox
**Theme used: Default (Raw)

**DESCRIPTION/SUMMARY: 
Fixes for journal titles and resume attachments for employment/education overlapped by details button.

**PRECONDITIONS:
1. Logged in user has a portfolio/page that includes:
a) journal blocks (3 types) and journal entries with long titles, and,
b) a resume that includes Education and Employment entries each with attachments with long names

**TEST STEPS:
Step1: Logged in user navigates to their portfolio/page and views each of the following blocks' details and comments modals:
1.1 Journal entries
1.2 Recent journal entries
1.3 Tagged journal entries
2.1 Resume Education entry with one or more attachments
2.2 Resume Employment entry with one or more attachments

Expected result: The entry artefact's name/title is clearly displayed (ie not partially obscured by the Details/Comments icons)
Actual result: As expected (see Resume attachment examples) ✔ Catalyst QA

** Attachment added: "Education and Employment attachment names not obscured by Details and Comment icons.png"
   https://bugs.launchpad.net/mahara/+bug/1827811/+attachment/5293372/+files/Education%20and%20Employment%20attachment%20names%20not%20obscured%20by%20Details%20and%20Comment%20icons.png

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1827811

Title:
  Move "Add comment" and "Details" into modal with "Comments"

Status in Mahara:
  In Progress

Bug description:
  This is part of the page revamp:
  https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/Page_layout_revision

  Currently, the "Add comment" and "Details" links at blocks that can
  have them, takes you to a separate page where you can view the
  artefact's metadata and can leave comments.

  When you view comments, they are already displayed in the modal
  directly on the page, but you can't leave a comment yet.

  The things to be done:

  - Combine comments, add comment, Details to "Comments and details" (or just comments or just details depending on what can be displayed) so you only have one link.
  - Clicking that link opens up a modal on the page that shows the artefacts details (if there are any) and also the comments, as well as allows you to leave comments if that is enabled. Please see the attached mock-up.

  This would also mean to review all the "Details" on blocks as some of
  them are not needed. For example, clicking the details link next to a
  plan task only shows that single plan task again without any
  additional details. The "Details" should only be there when there is
  additional metadata information but not simply repeating the block
  content.

  The title of the modal (the one in the green bar) would be the
  blocktype as the title of the block is listed below.

  A decision still needs to be made on whether comments can be paginated
  in the modal or if they are shown all one after another (which might
  get quite long).

  We are not changing anything else from the proposal as that requires
  Gridstack to be implemented first. This is a standalone usability
  improvement independent of Gridstack.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1827811/+subscriptions