mahara-contributors team mailing list archive

[Mahara Bot <1846102@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10385
Committed: https://git.mahara.org/mahara/mahara/commit/b6f6d03fe372a14f7d4953541ced79e058c97d53
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit b6f6d03fe372a14f7d4953541ced79e058c97d53
Author: Mitsuhiro Yoshida <mits@xxxxxxxxxxx>
Date:   Tue Oct 1 07:12:13 2019 +0900

Bug 1846102: Replaced Smarty function 'truncate' with
str_shorten_html().

For the places where we display message subject - as the multibyte
strings get truncated poorly

behatnotneeded

Change-Id: Ie97c943bdc2550807bb9a4987f51ed929349f9a9

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1846102

Title:
  Multibyte message subject on Inbox block corrupted

Status in Mahara:
  Fix Committed

Bug description:
  Multibyte message subjects on Inbox block are corrupted by Smarty function 'truncate'.
  So it's better for us to use the Mahara function str_shorten_html() instead as below.

  File to modify:
  theme/raw/plugintype/blocktype/inbox/templates/inboxmr.tpl

  Line:
  25

  [ Before ]
                      <span class="sr-only">{$i->strtype}</span>
                      {$i->subject|truncate:50}

  [ After ]
                      <span class="sr-only">{$i->strtype}</span>
                      {$i->subject|str_shorten_html:50:true|safe}

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1846102/+subscriptions