mahara-contributors team mailing list archive

[Rangi Daymond <1846102@xxxxxxxxxxxxxxxxxx>]

This patch has been verified by Robert so QA Testing unnecessary but
what was done has been included here.

**Launchpad/Bug: Bug 1846102 Multibyte message subject on Inbox block corrupted
                 https://bugs.launchpad.net/mahara/+bug/1846102
**Gerrit/Patchset: master with https://reviews.mahara.org/mahara refs/changes/85/10385/2
**Browser tested: Firefox
**Theme used: Default (Raw)

**DESCRIPTION/SUMMARY: 
Long multibyte i.e. Japanese email subjects are corrupted when they are shortened (invalid character/s inserted)

**PRECONDITIONS:
1. An existing user with their language set to Japanese is present
2. At least one institution is present that the above user is not yet an member of.

**TEST STEPS:
Step 1: Admin user is logged in and adds the target user to the target institution.
Step 2: The target user logs in and checks their inbox.

Expected result: The target user's inbox has no entries with invalid character/s in their subject.
Actual result: As expected, please see the attachment.
Catalyst QA testing: PASSED

** Attachment added: "Long email subjects do not display invalid continuation characters.png"
   https://bugs.launchpad.net/mahara/+bug/1846102/+attachment/5292993/+files/Long%20email%20subjects%20do%20not%20display%20invalid%20continuation%20characters.png

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1846102

Title:
  Multibyte message subject on Inbox block corrupted

Status in Mahara:
  Fix Committed

Bug description:
  Multibyte message subjects on Inbox block are corrupted by Smarty function 'truncate'.
  So it's better for us to use the Mahara function str_shorten_html() instead as below.

  File to modify:
  theme/raw/plugintype/blocktype/inbox/templates/inboxmr.tpl

  Line:
  25

  [ Before ]
                      <span class="sr-only">{$i->strtype}</span>
                      {$i->subject|truncate:50}

  [ After ]
                      <span class="sr-only">{$i->strtype}</span>
                      {$i->subject|str_shorten_html:50:true|safe}

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1846102/+subscriptions