← Back to team overview

mahara-contributors team mailing list archive

[Bug 1850219] [NEW] "Cancel" button on "Convert page layout" doesn't have proper class

 

Public bug reported:

When you have an old page that needs to be converted to Gridstack and
you are on the "Convert page layout" screen after having clicked the
"Edit" button for a page, you see three buttons.

The "Cancel" button doesn't have the correct class applied (see
screenshot).

Please follow the styleguide for the div around all three buttons. The
"Cancel" one needs 'class="default submitcancel form-group"'. Currently,
it seems that the class is applied to the form above the div but that
isn't applied.

Evonne can't fix it as it's tied to a form.

** Affects: mahara
     Importance: Low
         Status: Confirmed

** Attachment added: "conversion.png"
   https://bugs.launchpad.net/bugs/1850219/+attachment/5300996/+files/conversion.png

** Description changed:

  When you have an old page that needs to be converted to Gridstack and
  you are on the "Convert page layout" screen after having clicked the
  "Edit" button for a page, you see three buttons.
  
  The "Cancel" button doesn't have the correct class applied (see
  screenshot).
  
  Please follow the styleguide for the div around all three buttons. The
  "Cancel" one needs 'class="default submitcancel form-group"'. Currently,
  it seems that the class is applied to the form above the div but that
  isn't applied.
+ 
+ Evonne can't fix it as it's tied to a form.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1850219

Title:
  "Cancel" button on "Convert page layout" doesn't have proper class

Status in Mahara:
  Confirmed

Bug description:
  When you have an old page that needs to be converted to Gridstack and
  you are on the "Convert page layout" screen after having clicked the
  "Edit" button for a page, you see three buttons.

  The "Cancel" button doesn't have the correct class applied (see
  screenshot).

  Please follow the styleguide for the div around all three buttons. The
  "Cancel" one needs 'class="default submitcancel form-group"'.
  Currently, it seems that the class is applied to the form above the
  div but that isn't applied.

  Evonne can't fix it as it's tied to a form.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1850219/+subscriptions


Follow ups