mahara-contributors team mailing list archive

[Mahara Bot <1850219@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10496
Committed: https://git.mahara.org/mahara/mahara/commit/42479f2a10517675b8476908fa5097b26cfb2a5c
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 42479f2a10517675b8476908fa5097b26cfb2a5c
Author: Rebecca Blundell <rebeccablundell@xxxxxxxxxxxxxxx>
Date:   Tue Oct 29 14:25:27 2019 +1300

Bug 1850219: Cancel button missing 'btn' class

Add correct class to Cancel button on 'Convert page layout' page

Change-Id: I1e874247bb4527e0b1302c23a03c0c72b95aa394

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1850219

Title:
  "Cancel" button on "Convert page layout" doesn't have proper class

Status in Mahara:
  Confirmed

Bug description:
  When you have an old page that needs to be converted to Gridstack and
  you are on the "Convert page layout" screen after having clicked the
  "Edit" button for a page, you see three buttons.

  The "Cancel" button doesn't have the correct class applied (see
  screenshot).

  Please follow the styleguide for the div around all three buttons. The
  "Cancel" one needs 'class="default submitcancel form-group"'.
  Currently, it seems that the class is applied to the form above the
  div but that isn't applied.

  Evonne can't fix it as it's tied to a form.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1850219/+subscriptions