mahara-contributors team mailing list archive

[Mahara Bot <1850235@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10519
Committed: https://git.mahara.org/mahara/mahara/commit/d422eac0007668843d698e9785e3c630f6f6e79f
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    19.10_STABLE

commit d422eac0007668843d698e9785e3c630f6f6e79f
Author: Evonne <evonne@xxxxxxxxxxxxxxx>
Date:   Tue Oct 29 15:14:02 2019 +1300

Bug #1850235 Extra line above institution contact page

A. Corrected markup for conditions to remove first child's border-top
in list-groups.

B. Cannot be targetted as group admins get a set of buttons under the
page title and line. There is no situation currently where a list
occurs directly after page title without buttons.

behatnotneeded

Change-Id: I4e4af1702e4e8fdcf1cfb838c26ce2339f7cb591
(cherry picked from commit 84b8c38e238f58eda7552661cc3cbd895d4c185b)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1850235

Title:
  Extra 2nd line above a couple of different elements (plans and
  institution contact page)

Status in Mahara:
  Fix Committed

Bug description:
  There is an extra line above the first item on the institution
  contacts page and a plans overview page.

  A. Institution contacts page /institution/index.php?institution=

  1. Set up an institution.
  2. Add an admin and an institution staff member.
  3. Go to the staff member's profile page and click the name of the institution. That takes you to the institution contacts page.
  Expected result: No superfluous line.
  Actual result: There is an extra line above a person (see attachment).

  B) Group plan

  1. Set up a group with "Controlled" membership, "Everyone except ordinary members" to create and edit content.
  2. Add a regular group member.
  3. Set up a plan.
  4. Log in as regular group member.
  5. Navigate to the "Plans" section.
  Expected result: No extra line above the plan.
  Actual result: There is an extra line (see attachment). It happens because the regular group member doesn't have editing permissions and thus can't see the buttons that normally hang off of the line.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1850235/+subscriptions