← Back to team overview

mahara-contributors team mailing list archive

[Bug 1861055] [NEW] Verifier details should be cleared from DB when sign-off block verification opotion is disabled

 

Public bug reported:

It is possible to have a sign-off block with a disabled "Verify" option.
It is also possible to create a sign-off block with "Verify" enabled,
sign it off, have it verified then edit the block settings and set the
"Verify" option to disabled.  When this happens, the database
"view_signoff_verify" will contain the "verifier", "verifiedtime" and
"verified".  We should be clearing this as disabling "Verify" should
also revoke any previous verification.

To reproduce:

- Log in with UserA and create a new page and add a sign-off block and sign if off
- Share the page with UserB and grant them the role of peer
- Log in as UserB, navigate to the page and select "Verify".
- Check the database. Viewing "view_signoff_verify" shows new records for the verifier and verifiedtime for the view.
- Log in as UserA and edit the sign-off block and disable "Verify" option and save.
View page & database:
Expected:
- The sign-off block remains with sign-off but the verification option is removed.
- The database has cleared the verifier and the verified time and the verified fields.
Actual:
- page displays without verify option but database still has the verification details.

Mahara: 20.0_DEV

** Affects: mahara
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1861055

Title:
  Verifier details should be cleared from DB when sign-off block
  verification opotion is disabled

Status in Mahara:
  New

Bug description:
  It is possible to have a sign-off block with a disabled "Verify"
  option. It is also possible to create a sign-off block with "Verify"
  enabled, sign it off, have it verified then edit the block settings
  and set the "Verify" option to disabled.  When this happens, the
  database "view_signoff_verify" will contain the "verifier",
  "verifiedtime" and "verified".  We should be clearing this as
  disabling "Verify" should also revoke any previous verification.

  To reproduce:

  - Log in with UserA and create a new page and add a sign-off block and sign if off
  - Share the page with UserB and grant them the role of peer
  - Log in as UserB, navigate to the page and select "Verify".
  - Check the database. Viewing "view_signoff_verify" shows new records for the verifier and verifiedtime for the view.
  - Log in as UserA and edit the sign-off block and disable "Verify" option and save.
  View page & database:
  Expected:
  - The sign-off block remains with sign-off but the verification option is removed.
  - The database has cleared the verifier and the verified time and the verified fields.
  Actual:
  - page displays without verify option but database still has the verification details.

  Mahara: 20.0_DEV

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1861055/+subscriptions


Follow ups