mahara-contributors team mailing list archive

[Rangi Daymond <1850559@xxxxxxxxxxxxxxxxxx>]

- Code/Gerrit: https://reviews.mahara.org/#/c/10501/ Patch set 7
- Browser: Chrome; browser testing not required.
- Theme: Raw; theme testing not required.

Pre-conditions:
a. Log in as site admin.
b. Go to 'Create' > 'Files' and 
   - create a folder called 'animals'
   - in 'animals' create a folder called 'cats'
   - in 'cats' add some images files.
c. Go to 'Create' > 'Pages and collections' and create a page called 'Test page' with
   - a 'folder' block and select the folder 'cats' to display
   - an 'image' block and select one of the images in the 'cats' folder.
d. Go to 'Create' > 'Plans' and create a plan called 'Base plan', set 'template' and 'Assignment tasks' to 'Yes'.
e. In 'Base plan' create a task called 'Base plan - task 1' and under 'Assignment portfolio' choose 'Test page'.

Test scenario 1: Delete a task without making changes to the associated portfolio page.
Test steps:
1) Create a group called 'Group1'.
2) Choose 'Plans' in the group's menu bar and click 'New plan'.
3) Click the 'From template' button and choose 'Base plan' then save.
4) Click the 'Delete' button to delete 'Base plan - task 1' and click 'Delete plan' to confirm the delete action.
Expected results: 
    - ✔ the error message no longer displays, 
    - ✔ the first and only task 'Base plan - task 1' is removed.
5) Choose 'Files' in the group's menu bar then choose the 'viewfiles' folder.
Expected result: ✔ You should see a sub-folder that contains only a 'Parent folder' link.

Test scenario 2: Delete a task after having made changes to the associated portfolio page.
Test steps:
1) Create a group called 'Group2'.
2) Choose 'Plans' in the group's menu bar and click 'New plan'.
3) Click the 'From template' button
   - choose 'Base plan',
   - update the 'Title' to 'Group2 Test Plan'
   - save.
4) Click the displayed task's 'Open portfolio' icon
   - click 'Display page'
   - click 'Edit' and add a text block to the page, display the change.
5) Select 'Main menu' > 'Engage' > 'Groups
   - select Group2
   - click on the 'Plans' menu option
   - click on 'Group2 Test Plan'.
6) Click the 'Delete' button to delete 'Base plan - task 1' then click the 'Delete plan' button to confirm the delete action.
Expected results: 
    - ✔ the error message no longer displays, 
    - ✔ the first and only task 'Base plan - task 1' is removed.
7) Choose 'Files' in the group's menu bar then choose the 'viewfiles' folder.
Expected result: You should see
    - ✔ a 'Parent folder' link
    - ✔ a numbered folder with description 'Files copied from Test Page' containing the files & structure of pre-condition c.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1850559

Title:
  Problem with deleting a plan task

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed

Bug description:
  Error message when I wanted to delete a group plan that had 1 task

  [WAR] 98 (artefact/plans/tools/PlansTools.php:691) Trying to get property 'plugin' of non-object
  Call stack (most recent first):

      log_message("Trying to get property 'plugin' of non-object", 8, true, true, "/home/kristina/code/1910stable/htdocs/artefact/pla...", 691) at /home/kristina/code/1910stable/htdocs/lib/errors.php:521
      error(8, "Trying to get property 'plugin' of non-object", "/home/kristina/code/1910stable/htdocs/artefact/pla...", 691, array(size 8)) at /home/kristina/code/1910stable/htdocs/artefact/plans/tools/PlansTools.php:691
      artefact\plans\tools\PlansTools::deleteViewAndAssignedArtefacts(object(View)) at /home/kristina/code/1910stable/htdocs/artefact/plans/lib.php:1009
      ArtefactTypeTask->delete() at /home/kristina/code/1910stable/htdocs/artefact/lib.php:722
      ArtefactType->delete() at /home/kristina/code/1910stable/htdocs/artefact/plans/lib.php:319
      ArtefactTypePlan->delete() at /home/kristina/code/1910stable/htdocs/artefact/plans/plan/delete.php:94
      deleteplanform_submit(object(Pieform), array(size 2)) at /home/kristina/code/1910stable/htdocs/lib/pieforms/pieform.php:546
      Pieform->__construct(array(size 6)) at /home/kristina/code/1910stable/htdocs/lib/pieforms/pieform.php:168
      Pieform::process(array(size 6)) at /home/kristina/code/1910stable/htdocs/lib/mahara.php:5432
      pieform(array(size 6)) at /home/kristina/code/1910stable/htdocs/artefact/plans/plan/delete.php:80

  [WAR] 98 (artefact/plans/tools/PlansTools.php:692) Trying to get property 'artefacttype' of non-object
  Call stack (most recent first):

      log_message("Trying to get property 'artefacttype' of non-objec...", 8, true, true, "/home/kristina/code/1910stable/htdocs/artefact/pla...", 692) at /home/kristina/code/1910stable/htdocs/lib/errors.php:521
      error(8, "Trying to get property 'artefacttype' of non-objec...", "/home/kristina/code/1910stable/htdocs/artefact/pla...", 692, array(size 8)) at /home/kristina/code/1910stable/htdocs/artefact/plans/tools/PlansTools.php:692
      artefact\plans\tools\PlansTools::deleteViewAndAssignedArtefacts(object(View)) at /home/kristina/code/1910stable/htdocs/artefact/plans/lib.php:1009
      ArtefactTypeTask->delete() at /home/kristina/code/1910stable/htdocs/artefact/lib.php:722
      ArtefactType->delete() at /home/kristina/code/1910stable/htdocs/artefact/plans/lib.php:319
      ArtefactTypePlan->delete() at /home/kristina/code/1910stable/htdocs/artefact/plans/plan/delete.php:94
      deleteplanform_submit(object(Pieform), array(size 2)) at /home/kristina/code/1910stable/htdocs/lib/pieforms/pieform.php:546
      Pieform->__construct(array(size 6)) at /home/kristina/code/1910stable/htdocs/lib/pieforms/pieform.php:168
      Pieform::process(array(size 6)) at /home/kristina/code/1910stable/htdocs/lib/mahara.php:5432
      pieform(array(size 6)) at /home/kristina/code/1910stable/htdocs/artefact/plans/plan/delete.php:80

  [WAR] 98 (lib/errors.php:536) [Error]: Cannot instantiate abstract class ArtefactType
  Call stack (most recent first):

      exception(object(Error)) at Unknown:0

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1850559/+subscriptions