mahara-contributors team mailing list archive

[Lisa Seeto <1865400@xxxxxxxxxxxxxxxxxx>]

*** This bug is a security vulnerability ***

Public security bug reported:

>From https://simplesamlphp.org:

Background

SimpleSAMLphp allows users to report errors and failures to the system administrators via a web form. This web form gathers some contextual information automatically, but it also allows the user to provide their email address for follow-ups and a free-text explanation of what happened. Once submitted, the report is sent as an email to the administrative email address configured in the software.
Description

The www/erroreport.php script allows error reports to be submitted and
sent to the system administrator. Starting with SimpleSAMLphp 1.18.0, a
new SimpleSAML\Utils\EMail class was introduced to handle sending
emails, implemented as a wrapper of an external dependency.

This new wrapper allows us to use Twig templates in order to create the email sent with an error report. Since Twig provides automatic escaping of variables, manual escaping of the free-text field in www/errorreport.php was removed to avoid double escaping. However, for those not using the new user interface yet, an email template is hardcoded into the class itself in plain PHP. Since no escaping is provided in this template, it is then possible to inject HTML inside the template by manually crafting the contents of the free-text field.
Affected versions

SimpleSAMLphp versions 1.18.0 to 1.18.3, both inclusive.

We will need to upgrade to version 1.18.4

** Affects: mahara
     Importance: High
     Assignee: Lisa Seeto (lisaseeto)
         Status: In Progress

** Affects: mahara/18.10
     Importance: High
         Status: In Progress

** Affects: mahara/19.04
     Importance: High
         Status: In Progress

** Affects: mahara/19.10
     Importance: High
         Status: In Progress

** Affects: mahara/20.04
     Importance: High
     Assignee: Lisa Seeto (lisaseeto)
         Status: In Progress

** Also affects: mahara/18.10
   Importance: Undecided
       Status: New

** Also affects: mahara/19.10
   Importance: Undecided
       Status: New

** Also affects: mahara/20.04
   Importance: High
       Status: In Progress

** Also affects: mahara/19.04
   Importance: Undecided
       Status: New

** Changed in: mahara/19.10
   Importance: Undecided => High

** Changed in: mahara/19.04
   Importance: Undecided => High

** Changed in: mahara/18.10
   Importance: Undecided => High

** Changed in: mahara/19.10
    Milestone: None => 19.10.2

** Changed in: mahara/19.04
    Milestone: None => 19.04.4

** Changed in: mahara/18.10
    Milestone: None => 18.10.5

** Changed in: mahara/20.04
     Assignee: (unassigned) => Lisa Seeto (lisaseeto)

** Changed in: mahara/19.10
       Status: New => In Progress

** Changed in: mahara/19.04
       Status: New => In Progress

** Changed in: mahara/18.10
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1865400

Title:
  Security Upgrade SimpleSAML 1.17.7 to 1.18.4

Status in Mahara:
  In Progress
Status in Mahara 18.10 series:
  In Progress
Status in Mahara 19.04 series:
  In Progress
Status in Mahara 19.10 series:
  In Progress
Status in Mahara 20.04 series:
  In Progress

Bug description:
  From https://simplesamlphp.org:

  Background

  SimpleSAMLphp allows users to report errors and failures to the system administrators via a web form. This web form gathers some contextual information automatically, but it also allows the user to provide their email address for follow-ups and a free-text explanation of what happened. Once submitted, the report is sent as an email to the administrative email address configured in the software.
  Description

  The www/erroreport.php script allows error reports to be submitted and
  sent to the system administrator. Starting with SimpleSAMLphp 1.18.0,
  a new SimpleSAML\Utils\EMail class was introduced to handle sending
  emails, implemented as a wrapper of an external dependency.

  This new wrapper allows us to use Twig templates in order to create the email sent with an error report. Since Twig provides automatic escaping of variables, manual escaping of the free-text field in www/errorreport.php was removed to avoid double escaping. However, for those not using the new user interface yet, an email template is hardcoded into the class itself in plain PHP. Since no escaping is provided in this template, it is then possible to inject HTML inside the template by manually crafting the contents of the free-text field.
  Affected versions

  SimpleSAMLphp versions 1.18.0 to 1.18.3, both inclusive.

  We will need to upgrade to version 1.18.4

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1865400/+subscriptions