mahara-contributors team mailing list archive

[Mahara Bot <1868657@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10924
Committed: https://git.mahara.org/mahara/mahara/commit/386076f886970d8c7ab969456a776eff97bcac25
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    20.04_STABLE

commit 386076f886970d8c7ab969456a776eff97bcac25
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date:   Fri Apr 17 15:45:44 2020 +1200

Bug 1868657: detail block header for Image Gallery blocks that display
from individually images

Adding two functions to blocktype class to define if they show artefacts
details in a modal instead of showing details links for each one
on the block

behatnotneeded

Change-Id: If1f04bd2de1a1ceef46784ef0fe2fb6faa4194c2
(cherry picked from commit 4640e10aaba7389999c0232a705132ce4b8bffa1)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1868657

Title:
  Image Gallery blocks that display from individually images don't have
  the details block header

Status in Mahara:
  Fix Committed

Bug description:
  When an image gallery block is created with images selected from a
  folder it correctly displays a 'Details' block header over the block
  in 'Details' mode with the links to open the details in the modal.

  When an image gallery block is created with individually selected
  images, the image gallery will display but it is missing the details
  header.

  An investigation is needed as to how best to display the details
  header, i.e when displaying from a folder the gallery uses the same
  template as the folder block.  We should see what is possible when we
  display from individual images.

  Steps to reproduce:

  Pre-requisites:
  Have a site, a user (any role) who can log in and create a page and some image files uploaded.
  1. Log in and create a new page
  2. Add the Image Gallery block and choose and under "Image Selection" select "Choose individual images to display"
  3. Select images and then save the block
  5. Display the page and select "Details" mode
  Expected results:
  The Image gallery block displays with some kind of details header to reach the details modal
  Actual results:
  The Image gallery displays without any kind of details header

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1868657/+subscriptions