← Back to team overview

mahara-contributors team mailing list archive

[Bug 1890349] Re: SAML auth update user issues

 

** Changed in: mahara/20.10
       Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1890349

Title:
  SAML auth update user issues

Status in Mahara:
  In Progress
Status in Mahara 20.04 series:
  Confirmed
Status in Mahara 20.10 series:
  In Progress

Bug description:
  Currently if you have a user in Mahara that logs in via SAML and has
  update user option set then their admin/staff status is updated. If
  this info is not being passed in via SAML from IdP it means they are
  updated to be normal members.

  We should only do this updating if any of the SAML instance settings are set for:
  - rolesiteadmin
  - rolesitestaff
  - roleinstadmin
  - roleinststaff

  And if the particular one is not set to ignore updating this part of
  the user's profile

  Also we need to check that the following is correct
       if ($institutionrole == 'admin') {
           $institution->addUserAsStaff($user);
       }

  Should it be          $institution->addUserAsAdmin($user);

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1890349/+subscriptions


References