mahara-contributors team mailing list archive

[Robert Lyon <1890349@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

Currently if you have a user in Mahara that logs in via SAML and has
update user option set then their admin/staff status is updated. If this
info is not being passed in via SAML from IdP it means they are updated
to be normal members.

We should only do this updating if any of the SAML instance settings are set for:
- rolesiteadmin
- rolesitestaff
- roleinstadmin
- roleinststaff

And if the particular one is not set to ignore updating this part of the
user's profile

Also we need to check that the following is correct
     if ($institutionrole == 'admin') {
         $institution->addUserAsStaff($user);
     }

Should it be          $institution->addUserAsAdmin($user);

** Affects: mahara
     Importance: High
         Status: Confirmed

** Affects: mahara/20.04
     Importance: High
         Status: Confirmed

** Affects: mahara/20.10
     Importance: High
         Status: Confirmed

** Changed in: mahara
   Importance: Undecided => High

** Changed in: mahara
       Status: New => Confirmed

** Changed in: mahara
    Milestone: None => 20.10.0

** Also affects: mahara/20.04
   Importance: Undecided
       Status: New

** Also affects: mahara/20.10
   Importance: High
       Status: Confirmed

** Changed in: mahara/20.04
    Milestone: None => 20.04.2

** Changed in: mahara/20.04
   Importance: Undecided => High

** Changed in: mahara/20.04
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1890349

Title:
  SAML auth update user issues

Status in Mahara:
  Confirmed
Status in Mahara 20.04 series:
  Confirmed
Status in Mahara 20.10 series:
  Confirmed

Bug description:
  Currently if you have a user in Mahara that logs in via SAML and has
  update user option set then their admin/staff status is updated. If
  this info is not being passed in via SAML from IdP it means they are
  updated to be normal members.

  We should only do this updating if any of the SAML instance settings are set for:
  - rolesiteadmin
  - rolesitestaff
  - roleinstadmin
  - roleinststaff

  And if the particular one is not set to ignore updating this part of
  the user's profile

  Also we need to check that the following is correct
       if ($institutionrole == 'admin') {
           $institution->addUserAsStaff($user);
       }

  Should it be          $institution->addUserAsAdmin($user);

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1890349/+subscriptions