mahara-contributors team mailing list archive

[Mahara Bot <1890349@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11174
Committed: https://git.mahara.org/mahara/mahara/commit/fe31f2cd13818e4ef2f2fbf157a34eb3ba114c9c
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    master

commit fe31f2cd13818e4ef2f2fbf157a34eb3ba114c9c
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Aug 25 08:20:51 2020 +1200

Bug 1890349: Ignore SAML permission roles if not set in instance config

If we have not set 'roles' option in SAML config then we need to
ignore any of the changing admin/staff roles

Change-Id: I7ac908b35e9f91f1906f1230460909340d23735f
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1890349

Title:
  SAML auth update user issues

Status in Mahara:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Currently if you have a user in Mahara that logs in via SAML and has
  update user option set then their admin/staff status is updated. If
  this info is not being passed in via SAML from IdP it means they are
  updated to be normal members.

  We should only do this updating if any of the SAML instance settings are set for:
  - rolesiteadmin
  - rolesitestaff
  - roleinstadmin
  - roleinststaff

  And if the particular one is not set to ignore updating this part of
  the user's profile

  Also we need to check that the following is correct
       if ($institutionrole == 'admin') {
           $institution->addUserAsStaff($user);
       }

  Should it be          $institution->addUserAsAdmin($user);

  
  Thanks go to SWITCH for sponsoring this fix.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1890349/+subscriptions