mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #60657
[Bug 1893591] Re: improve block dimension saving on DB
Gerrit: https://reviews.mahara.org/#/c/11391/ patch set 3
Platforms: Ubuntu-Firefox, Win10-Chrome, Win10-Edge, iOS14-Safari & Android10-Chrome
Theme: Raw
Preconditions:
a) the 19.04_STABLE codebase is present with a clean database
b) The logged in Mahara site administrator account creates:
- 'Original 19.04 single block - page1' with one large text block, and,
- 'Original 19.04 4 block - page2', use 3 column layout & populate with:
* text block in column1
* image block in column2
* files to download block in column3
* image gallery block in column2 underneath the image block
c) The logged in account creates 5 copies (one for use in each browser above) of each page created in b)
d) Apply the patch and upgrade the database.
Repeat the following 3 test scenarios for each of the five platforms
given above, vary the site theme on each.
Test scenario 1: Verify that a simple page created in Mahara 19.04 can be upgraded to gridstack and successfully edited in Mahara 20.10.
Test steps:
1.1 Log in using the above Mahara account.
1.2 Navigate to 'Main menu' > 'Create' > 'Pages and collections' and select to view copy1 of page1.
Expected result: 'copy1.1 page1' displays successfully.
1.3 Select to edit 'copy1.1 page1' and agree to upgrade just this page to use grid stack.
Expected result: 'copy1.1 page1' displays in edit mode.
1.4 Select to add a new text block with content:
- after the existing text block, and then,
- before the existing text block.
Expected result: The new blocks and their content are added successfully.
1.5 Resize each of the blocks so they can be positioned next to each other in 3 columns then view the page.
Expected result: The blocks are resized and repositioned successfully, the page view is as expected.
Test scenario 2: Verify that a page with multiple different blocks created in Mahara 19.04 can be upgraded to gridstack and successfully edited in Mahara 20.10.
Test steps:
1.1 Log in using the above Mahara account.
1.2 Navigate to 'Main menu' > 'Create' > 'Pages and collections' and select to view copy1 of page2.
Expected result: 'copy1.1 page2' displays successfully.
1.3 Select to edit 'copy1.1 page2' and agree to upgrade just this page to use grid stack.
Expected result: 'copy1.1 page2' displays in edit mode.
1.4 Select to add a new block with content:
- before the existing blocks, and then,
- after the existing blocks.
Expected result: The new blocks and their content are added successfully.
1.5 Resize and reposition the blocks then view the page.
Expected result: The blocks are resized and repositioned successfully, the page view is as expected.
Test scenario 3: Verify that a page created in Mahara 19.04 can be copied and successfully edited in Mahara 20.10.
Test steps:
1.1 Log in using the above Mahara account.
1.2 Navigate to 'Main menu' > 'Create' > 'Pages and collections' and select to copy the original page2 then view it.
Expected result: copied 'copy1.2 page2 displays successfully.
1.3 Select to edit 'copy1.2 page2'
Expected result: 'copy1.2 page2' displays in edit mode - no upgrade prompt is displayed.
1.4 Select to add a new block with content:
- before the existing blocks, and then,
- after the existing blocks.
Expected result: The new blocks and their content are added successfully.
1.5 Resize and reposition the blocks then view the page.
Expected result: The blocks are resized and repositioned successfully, the page view is as expected.
Actual results - Ubuntu-Firefox ✔ PASSED (other 4 platforms not yet
tested)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1893591
Title:
improve block dimension saving on DB
Status in Mahara:
In Progress
Bug description:
When editing a page, the way we save the block dimensions is not efficient and can be improved.
For example if we add a block in the page, we will have an ajax call for every block that is moved, when we could have only one call for all the grid.
When resizing a block there are multiple ajax calls even before the resizing stops.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1893591/+subscriptions
References