mahara-contributors team mailing list archive

[Robert Lyon <1955607@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

When we fixed up some issues in HTML export in
https://reviews.mahara.org/#/c/11785/

We added $this->get_block_artefacts() function to return a list of
artefact IDs and set them as $artefactidarray

But then we override this variable with a new list of artefact IDs

Before this change exports could sometimes fail if a block being
exported contained connections to artefacts where the description
contained an embedded artefact in it, eg contained text
'artefact/file/download.php?file='

After the change in patch 11785 the error stopped because the associated
artefactids were not actually checked.

This patch will endeavor to fix things so both the old and new problems
go away

** Affects: mahara
     Importance: High
         Status: In Progress

** Affects: mahara/20.10
     Importance: High
         Status: New

** Affects: mahara/21.04
     Importance: High
         Status: New

** Affects: mahara/21.10
     Importance: High
         Status: New

** Affects: mahara/22.04
     Importance: High
         Status: In Progress

** Changed in: mahara
    Milestone: None => 22.04.0

** Also affects: mahara/20.10
   Importance: Undecided
       Status: New

** Also affects: mahara/21.10
   Importance: Undecided
       Status: New

** Also affects: mahara/21.04
   Importance: Undecided
       Status: New

** Also affects: mahara/22.04
   Importance: Undecided
       Status: New

** Changed in: mahara/21.10
   Importance: Undecided => High

** Changed in: mahara/22.04
   Importance: Undecided => High

** Changed in: mahara/21.04
   Importance: Undecided => High

** Changed in: mahara/20.10
   Importance: Undecided => High

** Changed in: mahara/22.04
       Status: New => In Progress

** Changed in: mahara/21.10
    Milestone: None => 21.10.1

** Changed in: mahara/21.04
    Milestone: None => 21.04.3

** Changed in: mahara/20.10
    Milestone: None => 20.10.4

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1955607

Title:
  Problems in HTML export

Status in Mahara:
  In Progress
Status in Mahara 20.10 series:
  New
Status in Mahara 21.04 series:
  New
Status in Mahara 21.10 series:
  New
Status in Mahara 22.04 series:
  In Progress

Bug description:
  When we fixed up some issues in HTML export in
  https://reviews.mahara.org/#/c/11785/

  We added $this->get_block_artefacts() function to return a list of
  artefact IDs and set them as $artefactidarray

  But then we override this variable with a new list of artefact IDs

  Before this change exports could sometimes fail if a block being
  exported contained connections to artefacts where the description
  contained an embedded artefact in it, eg contained text
  'artefact/file/download.php?file='

  After the change in patch 11785 the error stopped because the
  associated artefactids were not actually checked.

  This patch will endeavor to fix things so both the old and new
  problems go away

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1955607/+subscriptions