mahara-contributors team mailing list archive

[Mahara Bot <1955607@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/12390
Committed: https://git.mahara.org/mahara/mahara/commit/fcb3a7882053b188c221fdca77611f8fbd0c0fce
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    21.10_DEV

commit fcb3a7882053b188c221fdca77611f8fbd0c0fce
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Dec 23 16:23:15 2021 +1300

Bug 1955607: Getting HTML export associated files to export

Without causing errors

Change-Id: Id5aad1c65b63691ad4dd73b26b3cde79a6c773ed
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit db648e22e729044226068a228aea098ee3aecf03)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1955607

Title:
  Problems in HTML export

Status in Mahara:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  When we fixed up some issues in HTML export in
  https://reviews.mahara.org/#/c/11785/

  We added $this->get_block_artefacts() function to return a list of
  artefact IDs and set them as $artefactidarray

  But then we override this variable with a new list of artefact IDs

  Before this change exports could sometimes fail if a block being
  exported contained connections to artefacts where the description
  contained an embedded artefact in it, eg contained text
  'artefact/file/download.php?file='

  After the change in patch 11785 the error stopped because the
  associated artefactids were not actually checked.

  This patch will endeavor to fix things so both the old and new
  problems go away

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1955607/+subscriptions