mahara-contributors team mailing list archive

[Mahara Bot <1976410@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/c/mahara/+/12830
Committed: https://git.mahara.org/mahara/mahara/commit/ead4bf793c59638dbe6ae692ed923a78f85b6ca2
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    main

commit ead4bf793c59638dbe6ae692ed923a78f85b6ca2
Author: Gold <gold@xxxxxxxxxxxxxxx>
Date:   Tue May 31 14:35:38 2022 +1200

Bug 1976410: PHP8 Compatibility: auth

Updated MemcachedSession::read() to be compatible with what
session_set_save_handler() expects. Also added phpdocblock.

Chaining methods requires the object be returned while add_param()
returns a bool.

Replaces deprecated strftime() with date() and added strftimedaydate1 as
the new string with the date format.

Moved MNET_MDL_ASSIGN_SUBMISSION_MAHARA_PATH into a class for static
analysis discovery.

Change-Id: Idecdd9b2a9d2feede212ae24b6ddf9f3f34b8fb1

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1976410

Title:
  PHP 8 Compatibility: auth

Status in Mahara:
  Fix Committed

Bug description:
  This is to track patchsets that will bring the codebase up to be
  compliant with PHP 8.1.

  The initial run through will be on a top level directory basis. i.e.
  the directories below htdocs. It will focus on the results from the
  PHPStan and Phan static analysis tools.

  This bug tracks files in the auth dir.

  Testing will require identifying, from the patchset, where the code is
  used and then verifying that that area of the site still works in both
  PHP 7.4 and PHP 8.1.

  https://phpstan.org/
  https://github.com/phan/phan

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1976410/+subscriptions