← Back to team overview

mahara-contributors team mailing list archive

[Bug 1979372] Re: The 'show more' pagination needs to be a bit more flexible

 

** Changed in: mahara
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1979372

Title:
  The 'show more' pagination needs to be a bit more flexible

Status in Mahara:
  Fix Committed

Bug description:
  Currently when fetching new data with the 'show more' button it will
  replace the content parent HTML element of the button with the new
  content.

  This worked fine when the parent element was a <div> tag but fails if
  the parent HTML element of the button is something like a <TD> we end
  up replacing content of table rows into the table cell rather than
  replacing the table row.

  Need an adjustment on the 'show more' pagination where we can specify
  the closest HTML tag to do the replace content step on.

  
  To test:
  As this change is just to make the 'show more' pagination more robust the testing will be making sure current places work correctly still.

  So easiest test is to go to 'Pages and collection' page and have
  enough pages to cause the 'Show more' button to appear, say 14 page,
  and then clicking it appends more data to the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1979372/+subscriptions



References