mahara-contributors team mailing list archive

[Mahara Bot <1979372@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/c/mahara/+/12944
Committed: https://git.mahara.org/mahara/mahara/commit/3c0904ee6b3fc2c64e3a145e6ecadbc36fb3bbb8
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    main

commit 3c0904ee6b3fc2c64e3a145e6ecadbc36fb3bbb8
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Jun 22 12:56:46 2022 +1200

Bug 1979372: Alter 'Show more' pagination

Allow the 'Show more' pagination to indicate what HTML container to
replace with new content rather than relying on parent() as it might
not be the direct parent we want to replace.

Change-Id: I658dae2d3c02adc863cc62ac58d109f3752eb9ff
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1979372

Title:
  The 'show more' pagination needs to be a bit more flexible

Status in Mahara:
  Fix Committed

Bug description:
  Currently when fetching new data with the 'show more' button it will
  replace the content parent HTML element of the button with the new
  content.

  This worked fine when the parent element was a <div> tag but fails if
  the parent HTML element of the button is something like a <TD> we end
  up replacing content of table rows into the table cell rather than
  replacing the table row.

  Need an adjustment on the 'show more' pagination where we can specify
  the closest HTML tag to do the replace content step on.

  
  To test:
  As this change is just to make the 'show more' pagination more robust the testing will be making sure current places work correctly still.

  So easiest test is to go to 'Pages and collection' page and have
  enough pages to cause the 'Show more' button to appear, say 14 page,
  and then clicking it appends more data to the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1979372/+subscriptions