maria-developers team mailing list archive

[Kristian Nielsen <knielsen@xxxxxxxxxxxxxxx>]

Alexi1952 <Alexi1952@xxxxxxxxx> writes:

> Agree. BTW  tables_ok() is just the only member I had already #ifdef'ed out from Rpl_filter for client context.

Ah, I see.

> As for your suggestion to have a separate class, is it OK to do something like this?
>
> class Binlog_filter
> {
>   < ... all members from Rpl_filter except for tables_ok()
>      ... (will also check carefully for other members) ...>
> };
>
> class Rpl_filter: public Binlog_filter
> {
>   <... tables_ok() ...>
> };

Yes, that sounds good.

>
> BTW in this case declaring
>
>     Binlog_filter* binlog_filter;
>
> will look like more natural than
>
>     Rpl_filter* binlog_filter;
>
> (why indeed *replication filter* in mysqlbinlog which actully *doesn't replicate* :)

Indeed :-)

Thanks,

 - Kristian.