← Back to team overview

maria-developers team mailing list archive

Re: bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (knielsen:2763)



>>>>> "Arjen" == Arjen Lentz <arjen@xxxxxxxxxxxxx> writes:


>> Apparenty I forgot to add a test for setting these when I wrote the  
>> code :(

Arjen> Indeed, I broke it by accident and thus found the problem.

Arjen> There is actually more wrong, namely the --help --verbose help texts.
Arjen> I don't think you updated those with your changes/additions compared  
Arjen> to the microslow v1 patch you used as a base.

Sorry, what do you mean ?

Arjen> If you can find your original commit for this you might want to go  
Arjen> over that clean chunk again to make sure it's complete and consistent.
Arjen> I didn't have the time to find it in the history and it's rather more  
Arjen> difficult to spot potential issues in the big source.

I did go through the hunk in detail when I originally committed it.
Without knowing what to look for, it will not help to go over it once
more (by the same person).

I just checked the help messages for log_slow_filter and
log_slow_verbosity and they look fine.


Follow ups