maria-developers team mailing list archive

[Arjen Lentz <arjen@xxxxxxxxxxxxx>]

Hi Monty

On 14/10/2009, at 2:13 AM, Michael Widenius wrote:
> Arjen> There is actually more wrong, namely the --help --verbose  
> help texts.
> Arjen> I don't think you updated those with your changes/additions  
> compared
> Arjen> to the microslow v1 patch you used as a base.
>
> Sorry, what do you mean ?
>
> Arjen> If you can find your original commit for this you might want  
> to go
> Arjen> over that clean chunk again to make sure it's complete and  
> consistent.
> Arjen> I didn't have the time to find it in the history and it's  
> rather more
> Arjen> difficult to spot potential issues in the big source.
>
> I did go through the hunk in detail when I originally committed it.
> Without knowing what to look for, it will not help to go over it once
> more (by the same person).
>
> I just checked the help messages for log_slow_filter and
> log_slow_verbosity and they look fine.


I think they're incomplete and possibly the default that's shown is  
wrong in the text.
Just compare the option lists and the defaults with the text, that's  
all.


Cheers,
Arjen.
--
Arjen Lentz, Exec.Director @ Open Query (http://openquery.com)
Exceptional Services for MySQL at a fixed budget.

Follow our blog at http://openquery.com/blog/
OurDelta: enhanced builds for MySQL @ http://ourdelta.org