maria-developers team mailing list archive

[Sergei Golubchik <sergii@xxxxxxxxx>]

Hi, Paul!

On Dec 01, Paul McCullagh wrote:
> 
> This patch changes MariaDB code in one case:
> 
> File handler.cc, Line 1591
> 
> DBUG_ASSERT(total_ha_2pc == (ulong) opt_bin_log+1); // only InnoDB and binlog
> 
> This line has been commented out, because the assertions fails now
> that PBXT supports XA.
> 
> Although this assertion implies that not everything will work, I have
> not found any problem with the stability of MySQL due to the addition
> of PBXT XA.

Eh, no, not exactly. This assertion was to make sure that the ifdef'ed
code only runs when InnoDB is the only XA-capable engine.

As it's no longer the case, you need to remove the whole ifdef block,
not only the assert.
 
> PBXT XA can be disabled by setting pbxt_support_xa=0, it is enabled by
> default.
> 
Regards / Mit vielen Grüßen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@xxxxxxx>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Engineer/Server Architect
/_/  /_/\_, /___/\___\_\___/  Sun Microsystems GmbH, HRB München 161028
       <___/                  Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring