← Back to team overview

maria-developers team mailing list archive

Re: Rev 4: Added wrapper scripts for automated runs of sql-bench


Am 29.12.2009 um 15:09 schrieb Sergei Golubchik <sergii@xxxxxxxxx>:

Hi, Hakan!

On Dec 29, Hakan Kuecuekyilmaz wrote:
At file:///Users/hakan/work/monty_program/mariadb-tools/

revno: 4
revision-id: hakan@xxxxxxxxxxxx-20091229134253-zdbgd0ym9m7cokii
parent: knielsen@xxxxxxxxxxxxxxx-20091218103524-nof6wfpuku60r9rn
committer: Hakan Kuecuekyilmaz <hakan@xxxxxxxxxxxx>
branch nick: mariadb-tools
timestamp: Tue 2009-12-29 14:42:53 +0100
 Added wrapper scripts for automated runs of sql-bench.

=== added directory 'sql-bench'
=== added file 'sql-bench/run-sql-bench.sh'
--- a/sql-bench/run-sql-bench.sh    1970-01-01 00:00:00 +0000
+++ b/sql-bench/run-sql-bench.sh    2009-12-29 13:42:53 +0000
@@ -0,0 +1,236 @@
+# Run sql-bench for every given configuration file
+# we find in the directory $SQL_BENCH_CONFIGS.
+# Note: Do not run this script with root privileges.
+#   We use killall -9, which can cause severe side effects!

You can use

 killall -u `whoami`

not perfect, but still much safer.

I think that's not much safer. If run by root, then whoami will return root. I will add a simple check whether the script was started by root and if so, simply abort.

Thanks for noting out this one,