← Back to team overview

maria-developers team mailing list archive

Re: bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (monty:2825)

 

Michael Widenius <monty@xxxxxxxxxxxx> writes:

> === modified file 'storage/maria/ma_search.c'
> --- a/storage/maria/ma_search.c	2009-05-06 12:03:24 +0000
> +++ b/storage/maria/ma_search.c	2010-03-09 19:22:24 +0000

> +      info->int_keypos= info->keyread_buff + (ulonglong) info->int_keypos;
> +      info->int_maxpos= info->keyread_buff + (ulonglong) info->int_maxpos;

We now get new compiler warnings about this:

    ma_search.c:79: warning: cast from pointer to integer of different size
    ma_search.c:80: warning: cast from pointer to integer of different size

Not sure how to fix this ...

(If you want my advice, the better way would be not to do this at all. You're
actually adding two pointers here?!? Seems confusing, not to mention in
voilation of the C standard. There's probably a better way; not sure why you
did this, but eg. use a union if you want to store the value in the same
space).

 - Kristian.



Follow ups

References