maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxxx>]

Hi, Michael!

On Mar 28, Michael Widenius wrote:
> 
> #At lp:maria based on revid:sergii@xxxxxxxxx-20100324221239-7bj3zf8yv6bgclx1
> 
>  2834 Michael Widenius	2010-03-28
>       Fixed compiler warnings and sporadic failures in test cases

Hey, Monty,
may I ask what warnings did you get with gcc on these (see below)
absolutely legal C++ constructs ?

I'm not getting *any* warnings from, for example, item_create.cc, even
when I enable all possible warnings in gcc (besides "unused parameter"
warning).
 
> === modified file 'sql/item_cmpfunc.cc'
> --- a/sql/item_cmpfunc.cc	2010-03-04 08:03:07 +0000
> +++ b/sql/item_cmpfunc.cc	2010-03-28 18:10:00 +0000
> @@ -879,7 +879,7 @@ get_time_value(THD *thd, Item ***item_ar
>      Item_cache_int *cache= new Item_cache_int();
>      /* Mark the cache as non-const to prevent re-caching. */
>      cache->set_used_tables(1);
> -    cache->store(item, value);
> +    cache->store_longlong(item, value);
>      *cache_arg= cache;
>      *item_arg= cache_arg;
>    }
> === modified file 'sql/item_create.cc'
> --- a/sql/item_create.cc	2010-03-04 08:03:07 +0000
> +++ b/sql/item_create.cc	2010-03-28 18:10:00 +0000
> @@ -101,7 +101,7 @@ public:
>      @param arg1 The first argument of the function
>      @return An item representing the function call
>    */
> -  virtual Item *create(THD *thd, Item *arg1) = 0;
> +  virtual Item *create_1_arg(THD *thd, Item *arg1) = 0;
>  
>  protected:
>    /** Constructor. */
> @@ -127,7 +127,7 @@ public:
>      @param arg2 The second argument of the function
>      @return An item representing the function call
>    */
> -  virtual Item *create(THD *thd, Item *arg1, Item *arg2) = 0;
> +  virtual Item *create_2_arg(THD *thd, Item *arg1, Item *arg2) = 0;
>  
>  protected:
>    /** Constructor. */
> @@ -154,7 +154,7 @@ public:
>      @param arg3 The third argument of the function
>      @return An item representing the function call
>    */
> -  virtual Item *create(THD *thd, Item *arg1, Item *arg2, Item *arg3) = 0;
> +  virtual Item *create_3_arg(THD *thd, Item *arg1, Item *arg2, Item *arg3) = 0;
>  
>  protected:
>    /** Constructor. */
Regards,
Sergei