maria-developers team mailing list archive
-
maria-developers team
-
Mailing list archive
-
Message #02956
Review request: Remove a bunch of Windows warnings
Hi everyone,
This patch removes most of the Windows build warnings on Windows Vista
32 bit with Visual Studio 2005. I have only built with debug info using
the configuration in win\configure-mariadb.sh.
I added "namespace { char dummy; };" to empty files, because the VC++
linker gives a warning when it finds empty object files. These changes
are all guarded by #ifdef __WIN__. There are probably more of those when
compiling with different options and other things disabled.
In extra/yassl/taocrypt/src/algebra.cpp there is a re-definition of
DEBUG, when building with debug info. I removed it completely, because
it shouldn't be necessary at all.
In storage/xtradb/include/univ.i I changed the type of UNIV_PAGE_SIZE to
uint to get rid of a bunch of uint/int comparison warnings.
The xtradb sync0sync.c removes a warning about an unused variable.
Can I push this to lp:maria?
Bo.
ÿþ= = = m o d i f i e d f i l e ' e x t r a / y a s s l / t a o c r y p t / s r c / a l g e b r a . c p p '
- - - e x t r a / y a s s l / t a o c r y p t / s r c / a l g e b r a . c p p 2 0 0 9 - 0 2 - 1 3 1 6 : 4 1 : 4 7 + 0 0 0 0
+ + + e x t r a / y a s s l / t a o c r y p t / s r c / a l g e b r a . c p p 2 0 1 0 - 0 4 - 2 0 1 7 : 1 1 : 1 0 + 0 0 0 0
@ @ - 1 8 , 7 + 1 8 , 6 @ @
/ * b a s e d o n W e i D a i ' s a l g e b r a . c p p f r o m C r y p t o P P * /
# u n d e f N D E B U G
- # d e f i n e D E B U G / / G C C 4 . 0 b u g i f N D E B U G a n d O p t i m i z e >