maria-developers team mailing list archive
Mailing list archive
Re: proposed patch to add new handler error code
On Wed, May 18, 2011 at 5:55 AM, Michael Widenius <monty@xxxxxxxxxxxx> wrote:
> Sorry for the delay; My part of getting 5.3 ready took much longer
> than expected, but I am now finally done.
> (We are just waiting for 3 more patches from our team before we can
> declare 5.3 beta and this should not take long anymore).
> I will now go trough all of your patches and do my best to review and
> if they look ok add them to 5.3 tree.
>>>>>> "Zardosht" == Zardosht Kasheff <zardosht@xxxxxxxxx> writes:
> Zardosht> Hello all,
> Zardosht> In continuing with the suggestion to provide patches (given at the
> Zardosht> storage engine summit last friday), here is another one (last one for
> Zardosht> tonight).
> Zardosht> Our storage engine wanted to add the ability to return an error to the
> Zardosht> user that states that the disk is full. To do so, we added, we added
> Zardosht> the handler error code HA_ERR_DISK_FULL. When returned, the error
> Zardosht> ER_DISK_FULL (which already exists) is returned to the user.
> Zardosht> This does not have a bug number or worklog number. Is there something
> Zardosht> I should do besides sending this patch to the list?
> Index: mysys/my_handler_errors.h
> --- mysys/my_handler_errors.h (revision 25784)
> +++ mysys/my_handler_errors.h (revision 25785)
> @@ -64,6 +64,7 @@
> "File too short; Expected more data in file",
> "Read page with wrong checksum",
> "Too many active concurrent transactions",
> - "Row is not visible by the current transaction"
> + "Row is not visible by the current transaction",
> + "Disk full"
> This is ok; I will add it at and do a 'bzr gcommit' with your name.