← Back to team overview

maria-developers team mailing list archive

Re: [Commits] Rev 3100: Fix gcc 4.6 warnings about assigned but not used variables. in file:///home/bell/maria/bzr/work-maria-5.1-applebuild/

 

Oleksandr Byelkin <sanja@xxxxxxxxxxxx> writes:

> 27.10.2011 15:29, Kristian Nielsen пишет:
>> Oleksandr Byelkin<sanja@xxxxxxxxxxxx>  writes:
>>
>>> 26.10.2011 22:18, Michael Widenius пишет:
>>> [skip]
>>>> === modified file 'storage/pbxt/src/thread_xt.cc'
>>>> --- a/storage/pbxt/src/thread_xt.cc	2010-09-28 13:05:45 +0000
>>>> +++ b/storage/pbxt/src/thread_xt.cc	2011-10-25 14:24:24 +0000
>>>> @@ -485,7 +485,8 @@ static void thr_free_resources(XTThreadP
>>>>
>>>>    xtPublic void xt_bug(XTThreadPtr XT_UNUSED(self))
>>>>    {
>>>> -	static int *bug_ptr = NULL;
>>>> +	static int *bug_ptr __attribute__ ((unused));
>>>> +        bug_ptr= NULL;
>>>>    	
>>>>    	bug_ptr = NULL;
>>>>    }
>>> Th code was super strange before, I left it strange :) I think it is
>>> better to Percona to decide what to do with it (I sent them patch for
>>> 5.3).
>> Did you really send to Percona, or did you mean PBXT? Either way, PBXT it
>> should be :)
> Actually I sent whole patch to percona hoping they will take part they want.
>
> About pbxt - I was informed that nobody care about it, so did not do
> special movement... In any case the patch is published and code was
> preserved as it was :)

Ok, I misunderstood then. I thought you meant that you sent the above patch to
thread_xt.cc to Percona, I just wanted to point out that this is PBXT code,
not Percona code.

Sorry for any confusion.

 - Kristian.


References