maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxxx>]

Hi, Sanja!

On Dec 21, sanja@xxxxxxxxxxxx wrote:
> At file:///home/bell/maria/bzr/work-maria-10.0-cassandra/
> 
> ------------------------------------------------------------
> revno: 3482
> revision-id: sanja@xxxxxxxxxxxx-20121220233538-b171yhb9isogvd5h
> parent: sanja@xxxxxxxxxxxx-20121220204008-fox73otsp1lviqda
> committer: sanja@xxxxxxxxxxxx
> branch nick: work-maria-10.0-cassandra
> timestamp: Fri 2012-12-21 01:35:38 +0200
> message:
>   post review changes - interface (part 3)

> === modified file 'include/ma_dyncol.h'
> --- a/include/ma_dyncol.h	2012-12-20 20:40:08 +0000
> +++ b/include/ma_dyncol.h	2012-12-20 23:35:38 +0000
> @@ -100,6 +100,8 @@ struct st_dynamic_column_value
>  
>  typedef struct st_dynamic_column_value DYNAMIC_COLUMN_VALUE;
>  
> +/* old functions (depricated) */
> +#ifdef MADYNCOL_DEPRICATED

"deprEcated"

>  enum enum_dyncol_func_result
>  dynamic_column_create(DYNAMIC_COLUMN *str,
>                        uint column_nr, DYNAMIC_COLUMN_VALUE *value);
> @@ -133,75 +120,105 @@ dynamic_column_update_many(DYNAMIC_COLUM
>                             uint *column_numbers,
>                             DYNAMIC_COLUMN_VALUE *values);
>  enum enum_dyncol_func_result
> -dynamic_column_update_many_fmt(DYNAMIC_COLUMN *str,
> -                               uint add_column_count,
> -                               void *column_keys,
> -                               DYNAMIC_COLUMN_VALUE *values,
> -                               my_bool string_keys);
> -
> -enum enum_dyncol_func_result
>  dynamic_column_delete(DYNAMIC_COLUMN *org, uint column_nr);
>  
>  enum enum_dyncol_func_result
>  dynamic_column_exists(DYNAMIC_COLUMN *org, uint column_nr);
> +
>  enum enum_dyncol_func_result
> -dynamic_column_exists_named(DYNAMIC_COLUMN *str, LEX_STRING *name);
> +dynamic_column_list(DYNAMIC_COLUMN *org, DYNAMIC_ARRAY *array_of_uint);
> +
>  enum enum_dyncol_func_result
> -dynamic_column_exists_fmt(DYNAMIC_COLUMN *str, void *key, my_bool string_keys);
> +dynamic_column_get(DYNAMIC_COLUMN *org, uint column_nr,
> +                   DYNAMIC_COLUMN_VALUE *store_it_here);
> +#endif
>  
> -/* List of not NULL columns */
> +/* new functions */
>  enum enum_dyncol_func_result
> -dynamic_column_list(DYNAMIC_COLUMN *org, DYNAMIC_ARRAY *array_of_uint);
> +madyncol_create_many(DYNAMIC_COLUMN *str,

"madyncol" looks silly :)
let's agree on one namespace prefix and use it everywhere. either it's
ma_ like in

  ma_open
  ma_dyncol_create_many
  ma_alloc

or it's maria_ like in

  maria_open
  maria_dyncol_create_many
  maria_alloc

> +                           uint column_count,
> +                           uint *column_numbers,
> +                           DYNAMIC_COLUMN_VALUE *values,
> +                           my_bool new_string);

Regards,
Sergei