← Back to team overview

maria-developers team mailing list archive

regexp review

 

Hi!

Hi!

Everything is OK.

But there are some small issues:

   --- mysql-test/include/ctype_utf8mb4.inc 2010-03-05 08:17:19 +0000
   +++ mysql-test/include/ctype_utf8mb4.inc    2013-09-26 14:02:17 +0000
   @@ -234,15 +234,15 @@ set names utf8mb4;
     set names utf8mb4;

     # This should return TRUE
   -select  'вася'  rlike '[[:<:]]вася[[:>:]]';
   -select  'вася ' rlike '[[:<:]]вася[[:>:]]';
   -select ' вася'  rlike '[[:<:]]вася[[:>:]]';
   -select ' вася ' rlike '[[:<:]]вася[[:>:]]';
   +select  'вася'  rlike '\\bвася\\b';
   +select  'вася ' rlike '\\bвася\\b';
   +select ' вася'  rlike '\\bвася\\b';
   +select ' вася ' rlike '\\bвася\\b';

Is above unsupported pattern?

   === modified file 'sql/mysqld.cc'
   --- sql/mysqld.cc    2013-09-18 11:07:31 +0000
   +++ sql/mysqld.cc    2013-09-26 14:02:17 +0000
   @@ -1898,7 +1898,7 @@ void clean_up(bool print_message)
       delete global_rpl_filter;
       end_ssl();
       vio_end();
   -  my_regex_end();
   +  //my_regex_end();
     #if defined(ENABLED_DEBUG_SYNC)
       /* End the debug sync facility. See debug_sync.cc. */
       debug_sync_end();
   @@ -3904,10 +3904,10 @@ static int init_common_variables()
         return 1;
       item_init();
     #ifndef EMBEDDED_LIBRARY
   -  my_regex_init(&my_charset_latin1, check_enough_stack_size);
   +  //my_regex_init(&my_charset_latin1, check_enough_stack_size);
       my_string_stack_guard= check_enough_stack_size;
     #else
   -  my_regex_init(&my_charset_latin1, NULL);
   +  //my_regex_init(&my_charset_latin1, NULL);
     #endif
       /*
         Process a comma-separated character set list and choose

Remove it please (I think it was just forgotten).



Follow ups