maria-developers team mailing list archive

Thread
Date

Re: MDEV-5205 - MariaDB does not start if more than 128 cpu's are available

To: maria-developers@xxxxxxxxxxxxxxxxxxx
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Fri, 1 Nov 2013 18:22:34 +0100
In-reply-to: <20131101154838.1F7452C4129@mail.askmonty.org>
User-agent: Mutt/1.5.21 (2010-09-15)

Hi, Sergey!

On Nov 01, Sergey Vojtovich wrote:
> revno: 3939
> revision-id: svoj@xxxxxxxxxxx-20131101154841-egjkqc4e00mxc3ty
> parent: sanja@xxxxxxxxxxxxxxxx-20131029165036-f4wqcr2nrxzuwuuv
> committer: Sergey Vojtovich <svoj@xxxxxxxxxxx>
> branch nick: 5.5-mdev5205
> timestamp: Fri 2013-11-01 19:48:41 +0400
> message:
>   MDEV-5205 - MariaDB does not start if more than 128 cpu's are available
>   
> === modified file 'sql/threadpool_unix.cc'
> --- a/sql/threadpool_unix.cc	2013-06-22 12:02:03 +0000
> +++ b/sql/threadpool_unix.cc	2013-11-01 15:48:41 +0000
> @@ -907,6 +907,7 @@ int thread_group_init(thread_group_t *th
>    thread_group->pollfd= -1;
>    thread_group->shutdown_pipe[0]= -1;
>    thread_group->shutdown_pipe[1]= -1;
> +  thread_group->queue.empty();

ok, but please add to the definition of I_P_List::empty() a comment
that it's used in many places in the code instead of a constructor,
to initialize a bzero-ed I_P_List instance.

>    DBUG_RETURN(0);
>  }
>  
Regards,
Sergei