maria-developers team mailing list archive

Thread
Date

Re: Rev 4019: MDEV-5505: Assertion `! is_set()' fails on PREPARE SELECT with out of range in GROUP BY

To: maria-developers@xxxxxxxxxxxxxxxxxxx
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Sun, 26 Jan 2014 16:09:33 +0100
Cc: sanja@xxxxxxxxxxx
In-reply-to: <20140123125111.DE14D2C415F@mail.askmonty.org>
User-agent: Mutt/1.5.22 (2013-10-16)

Hi, Sanja!

On Jan 23, sanja@xxxxxxxxxxxx wrote:

> === modified file 'sql/sql_select.cc'
> --- a/sql/sql_select.cc	2014-01-21 13:27:36 +0000
> +++ b/sql/sql_select.cc	2014-01-23 12:50:54 +0000
> @@ -20463,7 +20463,8 @@ find_order_in_list(THD *thd, Item **ref_
>    if (!order_item->fixed &&
>        (order_item->fix_fields(thd, order->item) ||
>         (order_item= *order->item)->check_cols(1) ||
> -       thd->is_fatal_error))
> +       thd->is_fatal_error ||
> +       thd->is_error()))
>      return TRUE; /* Wrong field. */

Why not simply 

> -       thd->is_fatal_error))
> +       thd->is_error()))

can there be a fatal error that is not an error? :)

Regards,
Sergei