← Back to team overview

maria-developers team mailing list archive

Re: [Commits] Rev 3993: MDEV-5138 Numerous test failures in "mtr --ps --embedded"


Hi, holyfoot!

On Dec 02, holyfoot@xxxxxxxxxxxx wrote:
> At file:///home/hf/wmar/mdev-5138/
> ------------------------------------------------------------
> revno: 3993
> revision-id: holyfoot@xxxxxxxxxxxx-20131202104753-srqqm7hv1rtcurx4
> parent: holyfoot@xxxxxxxxxxxx-20131130142537-7j272euoaoy0svg1
> committer: Alexey Botchkov <holyfoot@xxxxxxxxxxxx>
> branch nick: mdev-5138
> timestamp: Mon 2013-12-02 14:47:53 +0400
> message:
>   MDEV-5138 Numerous test failures in "mtr --ps --embedded".
>           mysqltest in the 'embedded-server' mode runs queries in a separate thread,
>           but it didn't do so for the statements - they were run in the main thread.
>           That leads to inconsistencies.
>           When a test sets SESSION 'dbug' variable like
>                   SET SESSION debug_dbug="+d,warn_during_ha_commit_trans";
>           it is run as a plain query in that separate thread, so the main thread remains unaffected.
>           After that the statement run in the main thread doesn't produce expected 'dbug' errors,
>           so the test fail.
>           To fix that I made statement to be run in that special thread along with the plain queries.
>           That makes the environment consistent.

Ok to push. But sayng "statements" in the comment is a big misleading,
it'd be cleared if you'd say "prepared statements".