maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Jocelyn!

On Jul 08, Jocelyn Fournier wrote:
> Hi,
> 
> Why not displaying the ignored options as comments ?
> 
>    Jocelyn

Good question.
This is easy to do, I've just tried.

It might look confusing, though, the table from connect.alter test would
then be:

  SHOW CREATE TABLE t1;
  Table   Create Table
  t1      CREATE TABLE `t1` (
    `d` char(10) NOT NULL /* `FLAG`=11 */,
    `c` int(11) NOT NULL /* `FLAG`=0 */
  ) ENGINE=Aria DEFAULT CHARSET=latin1 PAGE_CHECKSUM=1 /* `TABLE_TYPE`=fix `FILE_NAME`='tf1.txt' `ENDING`=1 */

without comments it'd be a pure Aria table of

  SHOW CREATE TABLE t1;
  Table   Create Table
  t1      CREATE TABLE `t1` (
    `d` char(10) NOT NULL,
    `c` int(11) NOT NULL
  ) ENGINE=Aria DEFAULT CHARSET=latin1 PAGE_CHECKSUM=1

I cannot really decide which one is better :)
So, let's others voice their opinions.
I can push this change any minute.

Regards,
Sergei