← Back to team overview

maria-developers team mailing list archive

Re: [Commits] Rev 4275: MDEV-5867 ALTER TABLE t1 ENGINE=InnoDB keeps bad options when t1 ENGINE is CONNECT

 

Hi Sergei,

Le 08/07/2014 12:25, Sergei Golubchik a écrit :
Hi, Jocelyn!

On Jul 08, Jocelyn Fournier wrote:
Hi,

Why not displaying the ignored options as comments ?

    Jocelyn

Good question.
This is easy to do, I've just tried.

It might look confusing, though, the table from connect.alter test would
then be:

   SHOW CREATE TABLE t1;
   Table   Create Table
   t1      CREATE TABLE `t1` (
     `d` char(10) NOT NULL /* `FLAG`=11 */,
     `c` int(11) NOT NULL /* `FLAG`=0 */
   ) ENGINE=Aria DEFAULT CHARSET=latin1 PAGE_CHECKSUM=1 /* `TABLE_TYPE`=fix `FILE_NAME`='tf1.txt' `ENDING`=1 */


Perhaps something like :

  SHOW CREATE TABLE t1;
  Table   Create Table
  t1      CREATE TABLE `t1` (
    `d` char(10) NOT NULL /* `FLAG`=11 */,
    `c` int(11) NOT NULL /* `FLAG`=0 */
) ENGINE=Aria DEFAULT CHARSET=latin1 PAGE_CHECKSUM=1 /* Ignored Options : `TABLE_TYPE`=fix `FILE_NAME`='tf1.txt' `ENDING`=1 */


would be clearer ?

  Jocelyn


Follow ups

References