maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Sanja!

On Nov 02, sanja@xxxxxxxxxxxx wrote:
> At file:///home/bell/maria/bzr/work-maria-5.5-MDEV-6179/
> 
> ------------------------------------------------------------
> revno: 4341
> revision-id: sanja@xxxxxxxxxxxx-20141102133114-v46li6r2goyzhhp7
> parent: sanja@xxxxxxxxxxxx-20141031130729-dya4hci39x6zrv89
> committer: sanja@xxxxxxxxxxxx
> branch nick: work-maria-5.5-MDEV-6179
> timestamp: Sun 2014-11-02 14:31:14 +0100
> message:
>   MDEV-6179: dynamic columns functions/cast()/convert() doesn't play
>   nice with CREATE/ALTER TABLE
>   
>   Type attributes (length, dec, charset) which parsed to global
>   variables now saved and restored during prsing types which can
>   appeared in a expression.

Why did you create a stack in LEX, when bison generated parser already
has a stack of states? Also, there's no need to store that in LEX, it
doesn't need to live longer than the field_spec rule.

By coincidence I've spent a couple of last days rewriting this very part
of the parser. I've also fixed this bug without knowing it :)
But in 10.1, and the patch is too big to put it in 10.0, let alone 5.5,
so it's useless here.

Still, I tried to create a smaller patch for this bug in 5.5.
Please, review, it's on the commit list.

Regards,
Sergei