maria-developers team mailing list archive

Thread
Date

Re: [Commits] 953dd8d: MDEV-6997 MDEV-6996 MDEV-7002 MDEV-7006 MDEV-7009 MDEV-7012 MDEV-7015 MDEV-6977

To: maria-developers@xxxxxxxxxxxxxxxxxxx
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Sat, 29 Nov 2014 11:25:41 +0100
Cc: sanja@xxxxxxxxxxx
In-reply-to: <1415181904.802596.22413@bell-ThinkPad>
User-agent: Mutt/1.5.23 (2014-03-12)

Hi, sanja!

On Nov 05, sanja@xxxxxxxxxxx wrote:
> revision-id: 953dd8d87fea224e26d11452eb458c79ba098f4a
> parent(s): d6981391eb8f904135dfdedb5b90a7592b35e648
> committer: Oleksandr Byelkin
> branch nick: work-maria-10.1-sysvar4
> timestamp: 2014-11-05 11:05:01 +0100
> message:
> 
> MDEV-6997 MDEV-6996 MDEV-7002 MDEV-7006 MDEV-7009 MDEV-7012 MDEV-7015 MDEV-6977

I'd prefer a slightly more verbose commit comment. And don't forget -
first line is the subject. For example:

  Use NO_SET_STMT flag for more variables

  Fixes MDEV-6997 MDEV-6996 MDEV-7002 MDEV-7006 MDEV-7009 MDEV-7012 MDEV-7015 MDEV-6977

I won't comment on individual variables here, as you're simply disabling
them all. See my comments in Jira.

Regards,
Sergei